From 84ade944b89eca9913c6598a61fd0775aa620601 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Caol=C3=A1n=20McNamara?= Date: Sun, 26 Apr 2026 15:49:32 +0000 Subject: [PATCH] [PATCH] SdrEscherImport::RecolorGraphic reads but doesn't use FillColors MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit it never did, but at: commit 025bfa7e510bdab3ef93ad45a731fc25085ba3cc Date: Thu Apr 23 10:03:58 2015 +0100 cppcheck: unreadVariable the wrong choice was made wrt the dead store, the dead loop should have been fixed rather than let the unused fill colors accumulate in the globalcolors buffer. This function doesn't need to consume the unused data, all callers don't expect the entire record to be read so just drop the loop. Signed-off-by: Caolán McNamara Change-Id: I02bce4dd78dc566f18edc3d45603534c3f724cc3 Reviewed-on: https://gerrit.collaboraoffice.com/c/online/+/1689 (cherry picked from commit 07faeadace3d8d93225f9dd72c4f911e331070e2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205089 Tested-by: Jenkins Reviewed-by: Xisco Fauli (cherry picked from commit 9ba100c0d2131862c9356a86906921abc80d8f98) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/205097 Gbp-Pq: Name CVE-2026-8356.diff --- filter/source/msfilter/svdfppt.cxx | Bin 327054 -> 326624 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/filter/source/msfilter/svdfppt.cxx b/filter/source/msfilter/svdfppt.cxx index 20d3e5d9bc96d14ebd034f13efea452e1ae4aa59..51ee66f36e0f25bd228e53905b13216e603ff97b 100644 GIT binary patch delta 484 zcmeDCE&SlS@CHVY$wI-RljA+OOw;m<6f_iy6LaEAJ@ZP8jTAB!Y!wWwfs~Cxo_kJy zQeuvCeolT-v2%WDUI|cKTU$YMvZJ%`^anSXSf=m4$H+Um%~Npt9v2oK9_Nh2y!6x* z4FgSUuIVw#Op=q&dJ0c|;wdxzelru_bOU!rj>&RfI@9CQS@_t2hJqAM-x$j*$>o`s zl3D@LchHbYbh4$d-1H5{7}+Mj_hO%X!Algzfr_q2NJB;b`|?gM@fHB7kz0{^9=NU@UziJdG38=%WXn@s}RO#&E!m8UB!T$2+5C9Q3- zNGaGV7+7<0DF8unVorRiXI_c1k(NS%b7@ggYF>$dQD%B(USiJVb$;UB);N{0fs#KfI=pkYOQIHAb=OOEJ1}TENDJ{Q9K|>)6>`EYIqhMsM zkTp5bLs$qRW37;>U23#Oq`Q1dx%euNn;V4Y;c)llBdq(30*AHFU)1;WdQ}0 z`<9t=@&O;SN!~0%TCivWhP<{mC>*C39$*%qE^h$z9@$P^>?1PCn|1oUx6B++i^Sm; z!O{bgZQL3_Sx}T|YHLrQsLCiaeeE7b?#X$+0#hYf_$(lDpg6~tE